Fix ELF package correlations #3151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alex Goodman <wagoodman@users.noreply.github.com>
willmurphyscode
approved these changes
Aug 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We support a feature where binaries with ELF package notes can be correlated with other packages based on dynamic library requirements on the binary and file ownership information for other system packages. The result is that binaries that have ELF notes "magically" are associated via dependency relationships to RPM/Deb/etc packages that represent the dynamic libraries that the binary uses.
This functionality is currently not working ever since we switched the package type on these ELF packages from
BinaryPkgto the type that the package claims (e.g.RpmPkg). This PR addresses this issue by considering all packages based on the package metadata and not the package type (since an ELF package can be any type).